perf(ui): Speed up large compact selects - #119596
Closed
scttcper wants to merge 4 commits into
Closed
Conversation
TanStack Virtual now reads offset dimensions for the scroll element, which left our JSDOM tests with an empty virtual range. Update the shared fixture and affected tests to mock the dimensions the library actually uses. Memoize the existing item key callbacks so the new virtual core can keep its measurement cache across renders. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Avoid repeated selected-option lookups and skip empty search filtering work. Memoize virtualized rows and wire grid measurement refs so fast scrolling does less React work. Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-ljtkd8qor.sentry.dev |
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
Keep the trace logs URL filter coverage alongside the PR's row action test. Co-Authored-By: Codex <noreply@openai.com>
scttcper
commented
Jul 14, 2026
| if (selectedValues.has(option.value)) { | ||
| options.push(option); | ||
| if (options.length === selectedValues.size) { | ||
| break findSelectedOptions; |
Member
Author
There was a problem hiding this comment.
is the identifier too extra
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large CompactSelects do unnecessary work to derive the trigger label and empty search state. This switches selected option lookups to a Set, exits once the selected values are found, and skips the empty filtering pass.
Virtualized rows now skip rerendering retained options on every range update. Grid rows also forward the TanStack measurement props and keep a small overscan buffer so the project selector stays filled in during fast scrolling.
The scroll benchmark ran at 120 Hz over the same 3272 px distance. Stacks on #119595.